fix(bar): prevent outside text labels from overlapping tilted axis ticks - #7872
Conversation
|
Thanks for the PR! Our team will review and provide feedback. |
|
Hi maintainers, could someone please approve and trigger the GitHub Actions workflow for this PR? I'd love to make sure all the automated CI/CD tests pass successfully. Thank you! |
|
Until we get to this review, could you please look into the test failures and see if anything is broken/needs to be updated? |
|
Hi @vizansh ! I just spent some time reviewing the original issue #7822, and posted a comment with my thoughts on the root cause and the best approach for a fix. I think the best fix will require a different approach than what you've done here. Please feel free to continue working and pursue one of the fix approaches outlined in my comment if you like, or propose another approach. I'm happy to review. |
|
/review |
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
|
Hi @emilykl! Thank you so much for the detailed review and guidance! Those remaining inline errors were just leftover artifacts from my very first commit attempt. All of your suggested refactors and cleanups have been applied in the latest commits. Ready for another review whenever you have a moment! Thanks again for all your help! |
|
@vizansh A couple more cleanup suggestions to apply, then this should be good. I tried applying them myself but got an error so hopefully it works on your side. Thanks for the quick response! |
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
Removed redundant zeroBarDir assignment and adjusted targetX/Y calculations to eliminate axisPad.
|
Hi @emilykl! All the requested cleanups (axisPad reference removed, angle export restored, and duplicate zeroBarDir cleaned up) have been applied in the latest commits. Ready for your final review whenever you have a moment. Thanks again for all your guidance! |
|
Thank you so much @emilykl for the guidance, reviews, and the shoutout! I really appreciated working on this with you. Looking forward to contributing more in the future! |
3 participants
Fixes #7822
This pull request dynamically calculates the positioning for bar chart text labels when
textposition='outside'.Instead of using a static pixel margin, it looks up the active axis configuration and utilizes
.getBBox()to measure the exact live dimensions of the tilted or long axis labels. It then shifts the bar numbers by that precise footprint plus a clean visual buffer, entirely preventing overlaps with the top/right axis ticks.